+- Seekshell (https://seekshell.com)
+-- Forum: General (https://seekshell.com/forumdisplay.php?fid=1)
+--- Forum: Web3 & Blockchain (https://seekshell.com/forumdisplay.php?fid=26)
+--- Thread: Spot the vuln - Challenge 1 (/showthread.php?tid=566)
Spot the vuln - Challenge 1 - _blockchainer_ - 02-16-2023
Please login or register to view this content
RE: Challenge -for 3 points - BULL - 02-16-2023
how to contact you?
RE: Challenge -for 3 points - _blockchainer_ - 02-16-2023
(02-16-2023, 12:15 PM)BULL Wrote: how to contact you?
Post your answer as reply. I'll check the time to award the first one to answer.
RE: Challenge -for 3 points - BULL - 02-16-2023
function _approve(address owner, address spender, uint256 amount) internal virtual {
  require(spender != address(0), "ERC20: approve from the zero address");
  require(owner != address(0), "ERC20: approve to the zero address");
  _allowances[owner][spender] += amount;
  emit Approval(owner, spender, amount);
}
RE: Challenge -for 3 points - BULL - 02-16-2023
The changes I made:
1. Added a comma between spender and uint256 amount in the function signature.
2.Changed the address 6 to 0, which is the correct address for the zero address.
3.Removed the unnecessary single quotes around spender and uint256.
4. Fixed the indexing of _allowances by removing the space between [owner] and [spender].
RE: Challenge -for 3 points - _blockchainer_ - 02-17-2023
(02-16-2023, 12:21 PM)BULL Wrote: The changes I made:
1. Added a comma between spender and uint256 amount in the function signature.
2.Changed the address 6 to 0, which is the correct address for the zero address.
3.Removed the unnecessary single quotes around spender and uint256.
4. Fixed the indexing of _allowances by removing the space between [owner] and [spender].
sorry not, I don't even understand all of this claims. can you please elaborate.
RE: Challenge -for 3 points - _blockchainer_ - 02-17-2023
(02-16-2023, 12:18 PM)BULL Wrote: function _approve(address owner, address spender, uint256 amount) internal virtual {
  require(spender != address(0), "ERC20: approve from the zero address");
  require(owner != address(0), "ERC20: approve to the zero address");
  _allowances[owner][spender] += amount;
  emit Approval(owner, spender, amount);
}
This is same code ,I don't see a difference.